FEAT: Filter duplicate messages #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
carlwilson
commented
Mar 16, 2023
carlwilson
commented
- Message classes made hash/equals safe, for use in HashSet;
- RepInfo now uses a HashSet to store messages and returns a derived list;
- removed line left in target script by mistake; and
- added comments to target script.
- Message classes made hash/equals safe, for use in HashSet; - RepInfo now uses a HashSet to store messages and returns a derived list; - removed line left in target script by mistake; and - added comments to target script.
- error messages have no duplicates and are sorted by offset; - fixed a couple of issues with constructor calling to make message hash safe and ensure that severities are reported; - removed `Message` class constructors for consistent instantiation; - hash/equals safety tests for `Message` class; and - copied test files for issues where the number/sorting of issues has changed.
FIX: Duplicate error removal issues
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## integration #839 +/- ##
=================================================
+ Coverage 46.87% 47.04% +0.16%
- Complexity 1083 1097 +14
=================================================
Files 57 57
Lines 9050 9079 +29
Branches 1607 1622 +15
=================================================
+ Hits 4242 4271 +29
Misses 4274 4274
Partials 534 534
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.