Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Reporting PDF encryption for non reference. #810

Merged
merged 6 commits into from
Jan 11, 2023

Conversation

carlwilson
Copy link
Member

  • check that encryption isn't a dictionary before reporting encryption messages;
  • _encrypted set on the value of both reference OR dictionary not null;
  • removed unused imports and added string constant for Specification title;
  • added test files for non-indirect reference encryption:
    • test-root/corpora/errors/modules/PDF-hul/issue6010_1.pdf;
    • test-root/corpora/errors/modules/PDF-hul/issue6010_2.pdf; and
  • added results copy for new encryption tests.

samalloing and others added 4 commits July 22, 2022 17:21
- check that encryption isn't a dictionary before reporting encryption messages;
- _encrypted set on the value of both reference OR dictionary not null;
- removed unused imports and added string constant for Specification title;
- added test files for non indirect reference encryption:
  - `test-root/corpora/errors/modules/PDF-hul/issue6010_1.pdf`;
  - `test-root/corpora/errors/modules/PDF-hul/issue6010_2.pdf`; and
- added results copy for new encryption tests.
@carlwilson carlwilson added the bug A product defect that needs fixing label Jan 9, 2023
@carlwilson carlwilson added this to the JHOVE 1.28 milestone Jan 9, 2023
@carlwilson carlwilson requested a review from samalloing January 9, 2023 15:47
@carlwilson carlwilson self-assigned this Jan 9, 2023
@carlwilson carlwilson merged commit 0a7d6f4 into integration Jan 11, 2023
@carlwilson carlwilson deleted the fix/pdf/encrypt_dict branch January 13, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants