Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIFF: Continue validation even if data is unaligned #750

Closed

Conversation

david-russo
Copy link
Member

@david-russo david-russo commented May 27, 2022

Storing data unaligned to word or byte boundaries can decrease read performance but needn't halt file validation entirely as it doesn't prevent the file from being read. This will allow other potentially more serious issues to also be reported.

This commit also makes the 'byteoffset' configuration option affect the reporting of unaligned IFDs the same way it does unaligned IFD Entry values (by treating them as valid when set to 'true').

Storing data unaligned to word or byte boundaries can decrease read
performance but needn't halt file validation entirely as it doesn't
prevent the rest of the file from being read.

This commit also makes the 'byteoffset' configuration option affect the
reporting of unaligned IFDs the same way it does unaligned entry values.
@carlwilson carlwilson self-assigned this Nov 30, 2022
@carlwilson carlwilson added this to the JHOVE 1.28 milestone Nov 30, 2022
carlwilson added a commit that referenced this pull request Mar 16, 2023
Copy of #750 submitted by @david-russo, many thanks. Couldn't sort the conflict from the web UI.

Storing data unaligned to word or byte boundaries can decrease read performance but needn't halt file validation entirely as it doesn't prevent the file from being read. This will allow other potentially more serious issues to also be reported.

This commit also makes the 'byteoffset' configuration option affect the reporting of unaligned IFDs the same way it does unaligned IFD Entry values (by treating them as valid when set to 'true').
@carlwilson
Copy link
Member

I've taken this one in in #840 thanks @david-russo

@carlwilson carlwilson closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants