Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the orientation info from the Exif structure #748

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

tledoux
Copy link
Contributor

@tledoux tledoux commented May 18, 2022

Fixes #747

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Base: 46.22% // Head: 46.35% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (2a55bf7) compared to base (c1719c7).
Patch has no changes to coverable lines.

❗ Current head 2a55bf7 differs from pull request most recent head 4229de6. Consider uploading reports for the commit 4229de6 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##             integration     #748      +/-   ##
=================================================
+ Coverage          46.22%   46.35%   +0.12%     
+ Complexity          1056     1053       -3     
=================================================
  Files                 57       57              
  Lines               9057     9073      +16     
  Branches            1607     1609       +2     
=================================================
+ Hits                4187     4206      +19     
+ Misses              4330     4329       -1     
+ Partials             540      538       -2     
Impacted Files Coverage Δ
.../main/java/edu/harvard/hul/ois/jhove/Property.java 42.42% <0.00%> (-3.34%) ⬇️
...a/edu/harvard/hul/ois/jhove/NisoImageMetadata.java 75.99% <0.00%> (-0.20%) ⬇️
...edu/harvard/hul/ois/jhove/handler/JsonHandler.java 24.94% <0.00%> (+0.11%) ⬆️
...src/main/java/edu/harvard/hul/ois/jhove/Utils.java 69.84% <0.00%> (+7.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tledoux tledoux requested a review from carlwilson May 18, 2022 19:50
@carlwilson carlwilson added this to the JHOVE 1.28 milestone Nov 30, 2022
@carlwilson carlwilson mentioned this pull request Jan 13, 2023
@carlwilson carlwilson merged commit 4229de6 into openpreserve:integration Jan 13, 2023
@tledoux tledoux deleted the exifOrientation branch January 13, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Orientation info is not extracted from Exif header in JPEG photos
2 participants