FIX: Open JDK 11 build #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved the `Jhove` and `JhoveView` classes from default packageas Java 11 tooling complained; - updated `jhove-apps` POM to add new `Jhove` class package to manifest line; - updated windows batch and linux shell start scripts to add new `Jhove` class package to manifest line; and - updated Maven dependencies for `izpack -> 5.1.3` and `jacoco -> 0.8.7`for Java 11 compatibility.
- added JAXB API and implementation classes to `pom.xml`; and - updated coverage call Jacoco version number in `./jhove-bbt/scripts/bbt-jhove.sh b/jhove-bbt/scripts/bbt-jhove.sh`.
carlwilson
added
bug
Codecov Report
@@ Coverage Diff @@
## integration #716 +/- ##
==============================================
Coverage 45.63% 45.63%
Complexity 1046 1046
==============================================
Files 57 57
Lines 9149 9144 -5
Branches 1687 1682 -5
==============================================
- Hits 4175 4173 -2
+ Misses 4424 4422 -2
+ Partials 550 549 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JhoveandJhoveViewclasses from default packageas Java 11 tooling complained;jhove-appsPOM to add newJhoveclass package to manifest line;Jhoveclass package to manifest line;pom.xml;./jhove-bbt/scripts/bbt-jhove.sh b/jhove-bbt/scripts/bbt-jhove.shandizpack -> 5.1.3andjacoco -> 0.8.7for Java 11 compatibility.