Bump EPUBCheck in extension modules from 4.2.2 to 4.2.6 #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps EPUB Check version from 4.2.2 to 4.2.4.
Two changes to EPUBCheck were causing the tests to change: The first changes the error messages returned for validation of a non-EPUB: w3c/epubcheck#1134 The solution was to change the message count. The second downgrades the encrypted file message to INFO w3c/epubcheck#1136 The original implementation of the JHOVE EPUB module did not include INFO messages generated by EPUBCheck in the JHOVE report, but looking at the kinds of messages that might be listed as INFO messages I thought it might be useful to include them. The change to add INFO messages is reflected in this commit.
Codecov Report
@@ Coverage Diff @@
## integration #650 +/- ##
==============================================
Coverage 45.63% 45.63%
Complexity 1047 1047
==============================================
Files 57 57
Lines 9146 9146
Branches 1683 1683
==============================================
Hits 4174 4174
Misses 4422 4422
Partials 550 550 Continue to review full report at Codecov.
|
The changes identified an error in one of the test files that was not previously detected - specifically that "refines" property in the OPF must use the fragment identifier for local IDs. Updated the test file to reflect this.
karenhanson
changed the title
Updates to latest available version. No additional code changes are required to support this increment.
karenhanson
changed the title
carlwilson
approved these changes
Apr 6, 2022
carlwilson
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if dependabot will catch this, so submitting a manual PR for the latest version of EPUBCheck.
Two changes to EPUBCheck since 4.2.2 cause some tests to fail:
The solution to fixing the test was simply to change the expected message count.
This led to a decision point. The original implementation of the JHOVE EPUB module did not include INFO messages generated by EPUBCheck in the JHOVE report, but looking at the kinds of messages that might be listed as INFO messages I thought it might be useful to include them. I have added INFO messages to the report in this PR, but can roll back if this seems inappropriate. For reference, severity levels are defined here. The message values are here.
Update 4/14/2021: since the original PR, EPUBCheck 4.2.5 is now available, and so I've pushed a commit for that. No changes to the code were required, but the new checker identified an issue in one of the test files - this line in the OPF:
<meta refines="title" property="title-type">needed to be using the fragment reference:
<meta refines="#title" property="title-type">Update 1/26/2022: EPUBCheck 4.2.6 is now available and so I've incremented the version again. No additional changes required to the code as far as I can tell - tests still pass.