Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GUI usability #635

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Conversation

david-russo
Copy link
Member

@david-russo david-russo commented Jul 1, 2020

User-facing changes:

  • Improved GUI usability, including:
    • Added keyboard shortcuts for all menu bar items
    • Adjusted menu and window title text for clarity and consistency
    • Added Ctrl/Cmd+S shortcut for saving the contents of info. and result windows
    • Centered the main window and made dialog box positions relative to it
  • Added ability to analyze whole directories from the "File" menu (closes Allowing for a folder analysis from the GUI #628)
  • Prevented the default encoding from appearing twice in the "Save as..." dialog box (fixes GUI: in character encoding options, "UTF-8" appearing twice #627)

Housekeeping:

  • Modernized code using lambda expressions and enhanced loops
  • Removed unused code and clarified documentation

Also stops indiscriminately filtering out files which begin with
periods (.) on the false assumption that they should always be hidden.
This brings the behaviour in line with the command-line interface.

We *should* probably ignore files marked as hidden by default, but
we would first need to provide an option to disable that behaviour,
and make sure the implementation is system aware.
- Adds mnemonic keyboard shortcuts for all menu bar items.
- Adds Ctrl/Cmd+S shortcut for saving the contents of Info windows.
- Renames "Edit" menu to "Configuration".
- Corrects use of ellipses in menu items.
- Adjusts menu text for clarity and consistency.
- Centers main window and makes dialogs relative to their parent.
@david-russo david-russo added bug A product defect that needs fixing feature New functionality to be developed labels Jul 1, 2020
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #635 into integration will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             integration     #635   +/-   ##
==============================================
  Coverage          45.63%   45.63%           
  Complexity          1046     1046           
==============================================
  Files                 57       57           
  Lines               9149     9149           
  Branches            1687     1687           
==============================================
  Hits                4175     4175           
  Misses              4424     4424           
  Partials             550      550           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f077f...0cf906e. Read the comment docs.

@david-russo david-russo changed the title Improve GUI accessibility Improve GUI usability Jul 1, 2020
@carlwilson carlwilson merged commit 653b0a2 into openpreserve:integration Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing feature New functionality to be developed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowing for a folder analysis from the GUI GUI: in character encoding options, "UTF-8" appearing twice
2 participants