Fixes #375: Handle class cast from indirect object to simple object #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple object This fix for issue openpreserve#375 repairs a ClassCastException relating to casting from an indirect object to a simple object. This seems to be a common conversion through PdfModule that has been handled using the `resolveIndirectObject` method. The fix simply passes the object causing the problem into that method.
Codecov Report
@@ Coverage Diff @@
## integration #597 +/- ##
==============================================
Coverage 45.63% 45.63%
Complexity 1046 1046
==============================================
Files 57 57
Lines 9149 9149
Branches 1687 1687
==============================================
Hits 4175 4175
Misses 4424 4424
Partials 550 550 Continue to review full report at Codecov.
|
carlwilson
approved these changes
May 13, 2020
There was a problem hiding this comment.
So you're right that #596 covers similar ground. I think that there's likely a few of these in the code. Nice fix though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix for issue #375 repairs a ClassCastException relating to casting from an indirect object to a simple object. This seems to be a common conversion throughout the PdfModule that has been handled using the
resolveIndirectObjectmethod. This fix simply passes the object causing the problem into that method. I didn't write a test since this seems to be a repeated feature of the code, and the test would involve getting permission to use the file supplied with the issue. Please let me know if I should write it anyway.It looks like PR #596 may be responding to a similar issue.