Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in CoremessageConstants #500

Merged
merged 2 commits into from
Oct 18, 2019
Merged

typo in CoremessageConstants #500

merged 2 commits into from
Oct 18, 2019

Conversation

samalloing
Copy link
Collaborator

During the translation I noticed this weird sentence. When I look at the code I think what is meant is for and not or. So if you could confirm this, then I can change the translation

Thanks

Sam

samalloing and others added 2 commits October 18, 2019 13:57
During the translation I noticed this weird sentence. When I look at the code I think what is meant is *for* and not *or*. So if you could confirm this, then I can change the translation

Thanks

Sam
@carlwilson carlwilson self-requested a review October 18, 2019 12:06
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #500 into integration will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             integration     #500   +/-   ##
==============================================
  Coverage          49.54%   49.54%           
  Complexity           974      974           
==============================================
  Files                 55       55           
  Lines               7666     7666           
  Branches            1392     1392           
==============================================
  Hits                3798     3798           
  Misses              3412     3412           
  Partials             456      456
Impacted Files Coverage Δ Complexity Δ
...du/harvard/hul/ois/jhove/CoreMessageConstants.java 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b87800...1f596be. Read the comment docs.

@carlwilson
Copy link
Member

Confirmed @samalloing

@carlwilson carlwilson merged commit e3f9d93 into openpreserve:integration Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants