Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACT - Error ids for AIFF-hul #398

Merged
merged 10 commits into from
Mar 5, 2019
Merged

REFACT - Error ids for AIFF-hul #398

merged 10 commits into from
Mar 5, 2019

Conversation

carlwilson
Copy link
Member

  • added resources error message properties file for AIFF-hul messages and ids;
  • JhoveMessageFactory for AIFF-hul to handle resource loading; and
  • generated test data for AIFF-hul from WAV-hul examples.

- added resources error message properties file for `AIFF-hul` messages and ids;
- `JhoveMessageFactory` for `AIFF-hul` to handle resource loading; and
- generated test data for `AIFF-hul` from `WAV-hul` examples.
- using `JhoveMessageFactory` wrapped in `MessageConstants`; and
- added `ErrorMessages` property file for `IFF-hul`.
@carlwilson carlwilson added this to the v1.22-m4 Release milestone Mar 5, 2019
@carlwilson carlwilson self-assigned this Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #398 into integration will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #398      +/-   ##
=================================================
+ Coverage             48%   48.29%   +0.28%     
- Complexity           922      933      +11     
=================================================
  Files                 55       55              
  Lines               7626     7626              
  Branches            1378     1378              
=================================================
+ Hits                3661     3683      +22     
+ Misses              3476     3453      -23     
- Partials             489      490       +1
Impacted Files Coverage Δ Complexity Δ
.../edu/harvard/hul/ois/jhove/handler/XmlHandler.java 60.25% <0%> (+0.1%) 245% <0%> (+2%) ⬆️
...ain/java/edu/harvard/hul/ois/jhove/ModuleBase.java 48.6% <0%> (+0.93%) 67% <0%> (+1%) ⬆️
...in/java/edu/harvard/hul/ois/jhove/HandlerBase.java 67.35% <0%> (+1.03%) 46% <0%> (+1%) ⬆️
...va/edu/harvard/hul/ois/jhove/AESAudioMetadata.java 87.56% <0%> (+1.08%) 37% <0%> (+1%) ⬆️
...n/java/edu/harvard/hul/ois/jhove/ErrorMessage.java 64.7% <0%> (+11.76%) 6% <0%> (+1%) ⬆️
.../harvard/hul/ois/jhove/messages/JhoveMessages.java 47.05% <0%> (+17.64%) 5% <0%> (+2%) ⬆️
...d/hul/ois/jhove/messages/JhoveMessageFactImpl.java 75% <0%> (+75%) 3% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d734e...13ccb91. Read the comment docs.

@carlwilson carlwilson merged commit 519937a into integration Mar 5, 2019
@carlwilson carlwilson deleted the feat/aiff-err-nums branch April 29, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant