Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate valid mix10 and mix20 metadata (various values are Rational). #394

Merged
merged 3 commits into from
Mar 27, 2019

Conversation

tledoux
Copy link
Contributor

@tledoux tledoux commented Feb 28, 2019

The Brightness, ApertureBias and FlashEnergy properties are now Rational as needed for the versions 1.0 and 2.0 of the MIX schema.
Add unit test for all the new outputs.
Should also correct #387 : need for a sample file.

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #394 into integration will increase coverage by 0.83%.
The diff coverage is 69.09%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #394      +/-   ##
=================================================
+ Coverage          48.99%   49.82%   +0.83%     
- Complexity           955      976      +21     
=================================================
  Files                 55       55              
  Lines               7626     7631       +5     
  Branches            1378     1378              
=================================================
+ Hits                3736     3802      +66     
+ Misses              3412     3370      -42     
+ Partials             478      459      -19
Impacted Files Coverage Δ Complexity Δ
...edu/harvard/hul/ois/jhove/handler/TextHandler.java 0.54% <0%> (-0.01%) 2 <0> (ø)
.../edu/harvard/hul/ois/jhove/handler/XmlHandler.java 63.07% <100%> (+2.11%) 274 <0> (+19) ⬆️
...a/edu/harvard/hul/ois/jhove/NisoImageMetadata.java 74.64% <100%> (+0.86%) 175 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e10d89...1edea28. Read the comment docs.

@tledoux tledoux requested a review from carlwilson March 1, 2019 18:16
@tledoux tledoux added the bug A product defect that needs fixing label Mar 2, 2019
@tledoux tledoux self-assigned this Mar 6, 2019
@carlwilson carlwilson merged commit 5b89503 into openpreserve:integration Mar 27, 2019
Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the tests :)

@tledoux tledoux deleted the erroneousMix branch April 8, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants