Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate additional Java 5 compatibility checks to Java 8 #391

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

david-russo
Copy link
Member

@david-russo david-russo commented Feb 26, 2019

Previous updates missed the checks done in JHOVE application code (further addressing issue #372). This corrects that and comes with a little house-cleaning for good measure.

Also standardized system exit codes between command-line and
graphical interfaces.
Fixed Javadocs and standardized whitespace use and indentation.
@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #391 into integration will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             integration     #391   +/-   ##
==============================================
  Coverage          45.78%   45.78%           
  Complexity          3478     3478           
==============================================
  Files                368      368           
  Lines              30387    30387           
  Branches            5937     5937           
==============================================
  Hits               13913    13913           
  Misses             14042    14042           
  Partials            2432     2432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8876bc1...e78f1ff. Read the comment docs.

@carlwilson carlwilson merged commit d2931ab into openpreserve:integration Feb 26, 2019
@david-russo david-russo deleted the review branch February 26, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants