Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further migration to Java 1.8 #343

Merged
merged 1 commit into from
May 18, 2018

Conversation

david-russo
Copy link
Member

@david-russo david-russo commented May 8, 2018

This updates internal version checks, messages, and documentation to match the updated Java version requirement, and replaces a duplicate method with its Java 1.8 equivalent.

Closes #372

This updates internal version checks, messages, and documentation
to match the updated Java version requirement, and replaces a duplicate
method with its Java 1.8 equivalent.
@david-russo david-russo requested a review from carlwilson May 8, 2018 12:50
@codecov
Copy link

codecov bot commented May 8, 2018

Codecov Report

Merging #343 into integration will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #343      +/-   ##
=================================================
- Coverage          44.49%   44.48%   -0.01%     
+ Complexity          3418     3415       -3     
=================================================
  Files                368      368              
  Lines              30323    30321       -2     
  Branches            5988     5987       -1     
=================================================
- Hits               13491    13489       -2     
  Misses             14423    14423              
  Partials            2409     2409
Impacted Files Coverage Δ Complexity Δ
...du/harvard/hul/ois/jhove/CoreMessageConstants.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/edu/harvard/hul/ois/jhove/module/WaveModule.java 64.72% <0%> (-0.19%) 59 <0> (-3)
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 40.88% <0%> (ø) 41 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c839b1...d315544. Read the comment docs.

Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the README, cheers.

@carlwilson carlwilson merged commit fc6037c into openpreserve:integration May 18, 2018
@carlwilson carlwilson added the bug A product defect that needs fixing label Dec 13, 2018
@carlwilson carlwilson added this to the v1.22-m3 Reviewed milestone Dec 19, 2018
@david-russo david-russo deleted the java-1.8-migration branch February 12, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants