Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - NISO 1.0 Format Designation #323

Merged
merged 3 commits into from
Mar 29, 2018
Merged

Conversation

carlwilson
Copy link
Member

  • Niso 1.0 now outputs mandatory FormatName;
  • output added to TextHandler and XmlHandler;
  • bumped version number for TEXT and XML handlers;
  • updated release date for same; and
  • updated rights statement for same.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- Niso 1.0 now outputs mandatory FormatName; and
- output added to `TextHandler` and `XmlHandler`.
- bumped version number for TEXT and XML handlers;
- updated release date for same; and
- updated rights statement for same.
@carlwilson carlwilson self-assigned this Mar 28, 2018
@carlwilson carlwilson added the feature New functionality to be developed label Mar 28, 2018
@carlwilson carlwilson added this to the Release v1.20 milestone Mar 28, 2018
@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #323 into integration will increase coverage by <.01%.
The diff coverage is 36.53%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #323      +/-   ##
=================================================
+ Coverage          43.54%   43.55%   +<.01%     
- Complexity          3322     3324       +2     
=================================================
  Files                367      367              
  Lines              30159    30173      +14     
  Branches            5960     5969       +9     
=================================================
+ Hits               13132    13141       +9     
- Misses             14626    14631       +5     
  Partials            2401     2401
Impacted Files Coverage Δ Complexity Δ
...edu/harvard/hul/ois/jhove/handler/TextHandler.java 0.54% <3.84%> (-0.01%) 2 <1> (ø)
.../edu/harvard/hul/ois/jhove/handler/XmlHandler.java 58.84% <47.43%> (+0.06%) 236 <0> (+1) ⬆️
...va/edu/harvard/hul/ois/jhove/module/GifModule.java 51.62% <0%> (-0.13%) 28% <0%> (ø)
...edu/harvard/hul/ois/jhove/module/tiff/TiffIFD.java 37.71% <0%> (-0.03%) 189% <0%> (ø)
...u/harvard/hul/ois/jhove/module/wave/LinkChunk.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...va/edu/harvard/hul/ois/jhove/module/PdfModule.java 70.66% <0%> (+0.01%) 281% <0%> (ø) ⬇️
...edu/harvard/hul/ois/jhove/module/pdf/AProfile.java 34.14% <0%> (+0.12%) 42% <0%> (ø) ⬇️
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 41.01% <0%> (+0.12%) 42% <0%> (+1%) ⬆️
...va/edu/harvard/hul/ois/jhove/module/XmlModule.java 37.2% <0%> (+0.13%) 18% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94509dc...d259ff6. Read the comment docs.

@carlwilson carlwilson merged commit 83af942 into integration Mar 29, 2018
@carlwilson carlwilson deleted the fix/niso-mix-mime branch March 29, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality to be developed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant