FIX - Test for inconsistent xref for catalog. #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added test for inconsistent object number from xref table; - added constant for inconsistent catalog number; and - unit tests and resources for Doc Catalog. Closes #208
Codecov Report
@@ Coverage Diff @@
## integration #319 +/- ##
=================================================
+ Coverage 43.53% 43.54% +0.01%
- Complexity 3322 3323 +1
=================================================
Files 367 367
Lines 30160 30166 +6
Branches 5965 5967 +2
=================================================
+ Hits 13129 13136 +7
+ Misses 14631 14629 -2
- Partials 2400 2401 +1
Continue to review full report at Codecov.
|
david-russo
reviewed
Mar 16, 2018
| @@ -199,6 +196,7 @@ | |||
| private static final String DICT_KEY_LANG = "Lang"; | |||
| private static final String DICT_KEY_PAGES = "Pages"; | |||
| private static final String DICT_KEY_PAGE_LABELS = "PageLabels"; | |||
| private static final String DICT_KEY_TYPE = "Type"; | |||
There was a problem hiding this comment.
Mixed indentation white-space.
| @@ -0,0 +1,118 @@ | |||
| /** | |||
| * | |||
| */ | |||
| @@ -0,0 +1,95 @@ | |||
| /** | |||
| * | |||
| */ | |||
|
|
||
| /** | ||
| * | ||
| */ |
| // If the type key value is not Catalog | ||
| info.setWellFormed(false); | ||
| info.setMessage(new ErrorMessage(MessageConstants.ERR_DOC_CAT_TYPE_NO_CAT, 0)); | ||
| info.setMessage(new ErrorMessage(MessageConstants.ERR_DOC_CAT_TYPE_NO_CAT, 0)); |
- removed empty JavaDoc; - fixed inconsistent indentation; and - removed duplicate error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Inconsistent catalog indirect reference and object number #208