Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACT - WAVE Module message constants #285

Merged
merged 1 commit into from
Nov 1, 2017
Merged

REFACT - WAVE Module message constants #285

merged 1 commit into from
Nov 1, 2017

Conversation

carlwilson
Copy link
Member

  • tidied commented code in MessageConstants;
  • renamed constants to fit convention;
  • factored out String constants from WAVE Module;
  • bumped version number for WAVE module;
  • update test script to reflect changes; and
  • re-worked some messages so that single String required.

@carlwilson
REFACT - WAVE Module message constants
9c0522a 
- tidied commented code in `MessageConstants`;
- renamed constants to fit convention;
- factored out String constants from WAVE Module;
- bumped version number for WAVE module;
- update test script to reflect changes; and
- re-worked some messages so that single String required.
@carlwilson carlwilson merged commit 5ed0311 into integration Nov 1, 2017
@carlwilson carlwilson deleted the refact/wav-message-consts branch November 1, 2017 10:48
@carlwilson carlwilson added this to the Release v1.18 milestone Nov 6, 2017
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
@rgfeldman
openpreserve#285
a0eb75d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-russo david-russo david-russo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v1.18
Development

Successfully merging this pull request may close these issues.
2 participants
@carlwilson @david-russo