Handle uncaught module exceptions #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should make JHOVE more resilient to unstable modules, hopefully allowing it to recover and continue operations.
Codecov Report
@@ Coverage Diff @@
## integration #259 +/- ##
=================================================
- Coverage 41.99% 41.98% -0.01%
Complexity 3275 3275
=================================================
Files 392 392
Lines 31476 31482 +6
Branches 6123 6123
=================================================
+ Hits 13217 13218 +1
- Misses 15823 15828 +5
Partials 2436 2436
Continue to review full report at Codecov.
|
carlwilson
approved these changes
Jul 21, 2017
rgfeldman
added a commit
to rgfeldman/jhove
that referenced
this pull request
Apr 10, 2019
rgfeldman
added a commit
to rgfeldman/jhove
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should make JHOVE more resilient to unstable modules, hopefully allowing it to recover and continue operations on other files. This could help alleviate some issues incorporating JHOVE into some workflows, as mentioned in issue #256.