Bug fixes and code cleanup #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-russo
changed the title
Value 4 was introduced in PDF 1.5. This fixes a false invalid result.
Improved grammar; replaced iterators with for-each loops; disambiguated variable names; removed unused code; edited comments; made whitespace consistent; etc.
Removed declaration of support for non-PCMWAVEFORMAT-derived
("WAVEFORMAT") formats, which are currently unsupported.
Changed reported MIME type from `audio/x-wave` to `audio/vnd.wave`
per RFC 2361. This will allow support for the extended MIME type
`codec` parameter to be added in the future, also per the RFC.
Fixed indentation; replaced magic numbers; removed unused code; optimized imports; refactored minor methods; cleaned-up JavaDoc
- Corrected modules list - Updated JHOVE versions and dates - Updated copyright year - Made minor copy edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
audio/x-wavetoaudio/vnd.waveper RFC 2361