Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate valid mix and textMD metadata #220

Merged
merged 8 commits into from
Apr 27, 2017

Conversation

tledoux
Copy link
Contributor

@tledoux tledoux commented Apr 20, 2017

Add unit test for all the outputs.
Fixes #219

@codecov
Copy link

codecov bot commented Apr 20, 2017

Codecov Report

Merging #220 into integration will increase coverage by 2.19%.
The diff coverage is 94.11%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #220      +/-   ##
=================================================
+ Coverage          38.19%   40.38%   +2.19%     
- Complexity          3059     3124      +65     
=================================================
  Files                386      386              
  Lines              31321    31329       +8     
  Branches            6104     6105       +1     
=================================================
+ Hits               11962    12653     +691     
+ Misses             17188    16297     -891     
- Partials            2171     2379     +208
Impacted Files Coverage Δ Complexity Δ
.../edu/harvard/hul/ois/jhove/handler/XmlHandler.java 54.45% <94.11%> (+21.45%) 176 <0> (+21) ⬆️
...a/edu/harvard/hul/ois/jhove/NisoImageMetadata.java 68.06% <0%> (+7.92%) 154% <0%> (+24%) ⬆️
...in/java/edu/harvard/hul/ois/jhove/HandlerBase.java 66.32% <0%> (+10.36%) 45% <0%> (+9%) ⬆️
...java/edu/harvard/hul/ois/jhove/TextMDMetadata.java 64.28% <0%> (+11.22%) 22% <0%> (+10%) ⬆️
.../main/java/edu/harvard/hul/ois/jhove/Rational.java 100% <0%> (+14.28%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c861230...3dcc3c1. Read the comment docs.

@tledoux tledoux added the bug A product defect that needs fixing label Apr 26, 2017
@tledoux tledoux added this to the JHOVE hack day activities milestone Apr 26, 2017
@carlwilson
Copy link
Member

Hi @tledoux, I've reviewed this and it looks straight forward, I'll be merging shortly when the updated build completes.

@carlwilson carlwilson merged commit 6554246 into openpreserve:integration Apr 27, 2017
@tledoux tledoux deleted the issue219 branch April 27, 2017 08:00
@carlwilson carlwilson assigned carlwilson and tledoux and unassigned carlwilson Apr 27, 2017
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants