Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF-hul: Error ID possibly not shown for "Size entry missing in trailer dictionary" error #531

Closed
asciim0 opened this issue Nov 25, 2019 · 3 comments · Fixed by #579
Closed
Assignees
Labels
bug A product defect that needs fixing good-first-issue Issue suitable for inexperienced developers P1 High priority issues to be scheduled in the upcoming release
Milestone

Comments

@asciim0
Copy link
Contributor

asciim0 commented Nov 25, 2019

In the attached sample file, the error output for PDF-hul error "Size entry missing in trailer dictionary" error does not display the error ID in the output. However, the file also contains a "Validation ended prematurely due to an unhandled exception." error - I am not sure if the error ID was simply not assigned due the thrown unhandled error. The output is:

(...)
Size: 628
Format: PDF
Status: Unknown
SignatureMatches:
PDF-hul
ErrorMessage: Size entry missing in trailer dictionary
Offset: 607
ErrorMessage: Validation ended prematurely due to an unhandled exception.
MIMEtype: application/pdf
(...)

The according file is attached.

T04_015_trailer-no-size-key-value-pair.pdf

@carlwilson carlwilson self-assigned this Dec 10, 2019
@carlwilson carlwilson added bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release labels Dec 10, 2019
@carlwilson carlwilson added this to the v1.24-m4 Release milestone Dec 10, 2019
@carlwilson
Copy link
Member

The "Size entry missing.." error now has an ID PDF-HUL-74, the lack of an ID for the premature end is still an issue. Ideally that should be raised as a new issue and this closed if the 1.24 RC fixes the specific PDF error.

@carlwilson carlwilson modified the milestones: v1.24-m4 Release, Hack week tasks Apr 14, 2020
@carlwilson carlwilson added the good-first-issue Issue suitable for inexperienced developers label Apr 23, 2020
@carlwilson carlwilson removed their assignment Apr 27, 2020
@carlwilson
Copy link
Member

The issue needs triage to tease out the general issue covering the lack of error message for some of JHOVE's core error messages. If you're taking this issue on please contact @carlwilson for some tips to get started.

carlwilson added a commit that referenced this issue May 11, 2020
carlwilson added a commit that referenced this issue Apr 6, 2022
- added regression test files for #148, #358. #375 and #531; and
- patched results files for fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing good-first-issue Issue suitable for inexperienced developers P1 High priority issues to be scheduled in the upcoming release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants