Fix managed allocation #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user asks for a hostfile/hostlist inside of a managed allocation, make sure that rmaps filters these and maps processes based on them. Otherwise, it can result in inconsistent mappings across root and compute nodes if the user orders their hostfile differently than the resource manager. Signed-off-by: Austen Lauria <[email protected]>
For example: $. bsub -n 40 -m "node1 node2" mpirun -np 6 -host node1:2,node2:4 hostname would not map two hostname processes to node1 and four to node2. Instead, it would still think that each node1 and node2 had (for example) 20 cpu resources, and map accordingly. Signed-off-by: Austen Lauria <[email protected]>
Contributor
Author
|
I hand tested this as well under LSF + ompi master, and it seems to work the same as v4.0.x. I did run into build issues documented in #597. |
jjhursey
approved these changes
Jan 8, 2021
Member
|
Thanks for the fix. Yeah I need to get back to PR #597 - sorry for the delay on that. |
rhc54
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from open-mpi/ompi#8352