Skip to content

Add --display-comm{-finalize} to OMPI CLI #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2021
Merged

Add --display-comm{-finalize} to OMPI CLI #711

merged 1 commit into from
Jan 11, 2021

Conversation

@jjhursey
Copy link
Member

@jjhursey jjhursey commented Dec 22, 2020

No description provided.

@jjhursey jjhursey requested review from awlauria and dsolt December 22, 2020 02:24
@jjhursey
Copy link
Member Author

jjhursey commented Dec 22, 2020

Open MPI community requested this CLI option. Companion PR (though they are not dependent) open-mpi/ompi#8313

I choose -prot and -protlazy since those are the CLI names that Spectrum MPI uses.

@jjhursey jjhursey mentioned this pull request Dec 22, 2020
Merged
@jjhursey
Copy link
Member Author

jjhursey commented Jan 5, 2021

Per Open MPI Teleconf Jan. 5, 2021:

  • Put this out for comment.
  • If no objections then we will merge on Jan. 12, 2021 after OMPI teleconf.

@jjhursey
Copy link
Member Author

jjhursey commented Jan 7, 2021

Requires open-mpi/ompi#8313 from OMPI to work - otherwise, it is ignored.

@abouteiller
Copy link
Contributor

abouteiller commented Jan 7, 2021

Looks good but I'm not a big fan of the option name. protlazy looks like a control rather than a debug/display control.

What about --display-comm and display-comm-finalize, for uniformity with display-map ?

@jjhursey
Copy link
Member Author

jjhursey commented Jan 7, 2021

What about --display-comm and display-comm-finalize, for uniformity with display-map ?

I like that. Keeps it consistent with the other --display reporting options.

@jjhursey jjhursey changed the title Add -prot/-protlazy to OMPI CLI Add --display-comm{-finalize} to OMPI CLI Jan 8, 2021
@jjhursey
Copy link
Member Author

jjhursey commented Jan 8, 2021

I just pushed the adjustment to rename it from -prot/-protlazy to --display-comm/--display-comm-finalize

@rhc54 rhc54 merged commit 86da1f4 into openpmix:master Jan 11, 2021
@jjhursey jjhursey deleted the prot-ompi branch January 11, 2021 19:29
@jjhursey jjhursey mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsolt dsolt Awaiting requested review from dsolt

1 more reviewer

@awlauria awlauria awlauria approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jjhursey @abouteiller @awlauria @rhc54