Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table download button - suggestion for change #157

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

LDSamson
Copy link
Collaborator

As discussed here: #153 (comment)

@LDSamson LDSamson changed the base branch from ac-96 to dev January 10, 2025 11:14
@LDSamson LDSamson changed the base branch from dev to ac-96 January 10, 2025 11:14
Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment below for you to consider. Overall, this task was is executed much more concisely inside datatable_custom(). Looks great!

R/fct_data_helpers.R Outdated Show resolved Hide resolved
R/mod_common_forms.R Outdated Show resolved Hide resolved
@LDSamson LDSamson marked this pull request as ready for review January 14, 2025 08:21
Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aclark02-arcus aclark02-arcus merged commit 380d07c into ac-96 Jan 14, 2025
@LDSamson LDSamson deleted the ls_table_download_change_suggestion branch January 15, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants