Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devex #147

Merged
merged 46 commits into from
Dec 5, 2024
Merged

Update devex #147

merged 46 commits into from
Dec 5, 2024

Conversation

jthompson-arcus
Copy link
Collaborator

No description provided.

jthompson-arcus and others added 30 commits November 13, 2024 13:02
@jthompson-arcus
Migrate to review_records from review_row
7c58504
@jthompson-arcus
Update test-fct_SQLite.R
b271add
@jthompson-arcus
Update test-mod_review_forms.R
39d8da1
@jthompson-arcus
Update test-mod_main_sidebar.R
43931ed
@jthompson-arcus
Fix R CMD checks
d311ab1
@jthompson-arcus
Fix db_get_review() example
ccd9bb1
@jthompson-arcus
Helps if you update documentation
0743880
@jthompson-arcus
Only UPDATE reviews when review status is changed
e5e8acb
@jthompson-arcus
Resolve merge conflicts with jt-113-simplify_review_process
2551970 
Merge branch 'jt-113-simplify_review_process' into jt-99-review_by_row

# Conflicts:
#	R/fct_SQLite.R
#	man/db_save_review.Rd
#	tests/testthat/test-fct_SQLite.R
#	tests/testthat/test-mod_review_forms.R
@jthompson-arcus
Keep current structure for enabling reviews
d863300
@jthompson-arcus
Resolve merge conflict with dev
6ad27a6 
Merge branch 'dev' into jt-99-review_by_row

# Conflicts:
#	R/mod_review_forms.R
#	tests/testthat/test-mod_review_forms.R
@jthompson-arcus
Generalize db_get_review()
a23b462
@jthompson-arcus
Update version and NEWS
6990cf1
@jthompson-arcus
Update scenario description for two rows
3db4274
@jthompson-arcus
Update language from row to records
1c675a9
@jthompson-arcus
Grab un-duplicated rv_records
c177a30
@jthompson-arcus
Remove unnecessary dplyr::select()
d2fa0d6
@jthompson-arcus
Remove unneeded dplyr::distinct()
de24777
@jthompson-arcus
Return db_get_review() when ... is empty
d372afa
@LDSamson
Update to latest test-coverage. Remove package installation since it …
8261441 
…is redundant
@LDSamson
Fix codecov arguments for codecov-actvion V5 https://github.com/marke…
0f4a693 
…tplace/actions/codecov#v5-release
@LDSamson
Print codecov results again
c547862
@jthompson-arcus
Update test-mod_review_forms.R
f28f174
@LDSamson
Update version and news
047b459
@jthompson-arcus
Update only one table in db_save_review()
7e26f83
@jthompson-arcus
Fix oopsies
ad3f05e
@jthompson-arcus
Merge pull request #139 from openpharma/ls_update_codecov
b2bd9bb 
Fix codecov uploads
@jthompson-arcus
Fix merge conflict with dev
939566f 
Merge branch 'dev' into jt-99-review_by_row

# Conflicts:
#	DESCRIPTION
#	inst/golem-config.yml
@jthompson-arcus
Add test for db_get_review() when no filters are specified
439d14b
@jthompson-arcus
Fix updated_items_memory
0079348
LDSamson and others added 16 commits November 28, 2024 14:26
@LDSamson
Don't export db_get_review anymore
ca83997
@LDSamson
Update documentation
0f680cd
@LDSamson
Ensure db_get_review errors before sending a db query if ... cannot…
a08c510 
… be coerced to a data frame
@LDSamson
Add additional tests
f7ba04a
@LDSamson
Use more consistent naming in the save review process
205896f
@LDSamson
Change a dplyr::filter call to base R filter for performance reasons
b8f3f52
@LDSamson
Ensure that updated_records_memory has the same columns as in the db
0154355
@LDSamson
Ensure tests will fail if there is a review discrepancy
f0144a2
@LDSamson
Export review_save_error to ensure errors are captured when saving re…
5360760 
…view in in a shinytest2 test
@LDSamson
Update snaps
88f5b04
@LDSamson
Also update mod_main_sidebar snaps
23b6e91
@LDSamson
Change to base R filter
6ce5827
@LDSamson
Fix review saving by selecting correct rows to update within the appl…
0e8ecc7 
…ication
@LDSamson
Remove the (now) redundant filtering by timestamp for updated_records…
d8e24d4 
…_memory
@LDSamson
Merge pull request #137 from openpharma/jt-99-review_by_row
5845568 
Review by records instead of `subject_id` & `form_id` "rv_row"
@jthompson-arcus
Resolve merge conflicts with dev
05a3ee4 
Merge branch 'dev' into jt-update_devex

# Conflicts:
#	DESCRIPTION
@jthompson-arcus jthompson-arcus marked this pull request as ready for review December 4, 2024 18:02
aclark02-arcus
aclark02-arcus approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Merging

@aclark02-arcus aclark02-arcus merged commit f896b4f into devex Dec 5, 2024
5 checks passed
@jthompson-arcus jthompson-arcus deleted the jt-update_devex branch December 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclark02-arcus aclark02-arcus aclark02-arcus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jthompson-arcus @aclark02-arcus @LDSamson