Update requirements to include latest flatten-tool, and libcoveweb from PyPI #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the `"format": "date"` fix that we want OpenDataServices/flatten-tool#358 #35
(because the package is now fixed OpenDataServices/lib-cove-web#39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once deployed, this will fix #35, as that's fixed in the latest flatten-tool release.
libcoveweb is now on PyPI, so can be upgraded like a normal package, instead of a git url.
This also switches to pip's new 2020-resolver in the
update_requirements.shscript. This will be the default from the October pip release.The new resolver is stricter, but easier to reason about. At the moment if "A requires B which requires D(v1)" and "A requires C which requires D(v2)" then the installation will happen successfully, with D(v1) or D(v2) picked depending on the order the requirements are listed. With the new resolver, this case will error out, and D will not be installed.