Display "comparing budget" on right/bottom #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a minor UI snag that I noticed during the OpenBudget demo: I
found myself wanting to compare the budget in a left-to-right fashion
(or top-to-bottom) chronologically.
By default, the budget I am "comparing" is the FY17-18 one. In general,
the default will probably always be the most recent available budget. I'd
argue that we should display the bars such that FY16-17 is
to the left or top, and FY17-18 (as the most recent budget) is to the right or
bottom by default.
Perhaps running past CUT group, but hey, I just wanted a chance to read through
this code and thought this would be a nice tiny change to get my feet wet.
Before:

After:

(The color coding helps quite a bit in understanding what happens when
the budget to compare against is changed.)
The one gotcha here is that the colors array is given by D3. I was going
to just switch the default budgets around, but I like that the current
budget is in green rather than orange.