Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added commons math again #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added commons math again #55

wants to merge 1 commit into from

Conversation

PtrMan
Copy link
Contributor

@PtrMan PtrMan commented Aug 31, 2018

No description provided.

@PtrMan PtrMan requested a review from patham9 August 31, 2018 19:02
@codecov
Copy link

codecov bot commented Aug 31, 2018 •
edited
Loading

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #55   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          57     57           
  Lines        7198   7198           
  Branches     1198   1198           
=====================================
  Misses       7198   7198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0cea44...08a06e2. Read the comment docs.

@patham9
Copy link
Member

patham9 commented Aug 31, 2018

what for?

patham9
patham9 requested changes Aug 31, 2018
View reviewed changes
Copy link
Member

@patham9 patham9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be added when it's used. dependencies won't be added just for the sake of adding them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patham9 patham9 patham9 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PtrMan @patham9