improved dialog response checking #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hual
requested changes
Mar 29, 2024
Hual
approved these changes
Mar 31, 2024
ksenonadv
approved these changes
Apr 12, 2024
AmyrAhmady
added a commit
that referenced
this pull request
Jun 28, 2024
AmyrAhmady
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maded:
now, when processing a response to a dialogs next types: "DIALOG_STYLE_LIST", "DIALOG_STYLE_TABLIST_HEADERS", "DIALOG_STYLE_TABLIST" the number of lines in the body of the dialogue is counted, and if the "listitem" value that the player sent is more than we counted - such a response is ignored.
limited the response parametr value from 0 to 1
Feat #866 and #867
P.S: Implemented through a loop, not a "Impl::count", since in this case the loop should be faster