Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup style and update version #10

Merged

Conversation

tmcqueen-materials
Copy link

@tmcqueen-materials tmcqueen-materials commented Jan 3, 2025

Apparently version v1.2.4 was tagged without updating the code version number. Fix that, and to allow a new pushed version, use then a "post1" (see https://peps.python.org/pep-0440/ ) version.

Also includes two "black" style changes.

TLDR: merge this PR, tag the new version as "v1.2.4.post1", and then push a new version to PyPI (the tagged 1.2.4 was not pushed to PyPI, see https://pypi.org/project/openmsitoolbox/#history , no need to push 1.2.4, just push 1.2.4.post1 ).

Thank you!

@davidelbert davidelbert merged commit d75f682 into openmsi:main Jan 6, 2025
@davidelbert davidelbert self-requested a review January 6, 2025 16:47
@davidelbert davidelbert self-assigned this Jan 6, 2025
@tmcqueen-materials tmcqueen-materials deleted the fixup-style-new-release branch January 7, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants