Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-4342: Split allergy form fields #2232

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Muppasanipraneeth
Copy link
Contributor

@Muppasanipraneeth Muppasanipraneeth commented Feb 6, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

By the discussion on the issue thread issue link

Context for Removing Onset Date Field:

  • The "Onset Date" field for allergies is not meaningful since we rarely know when a person first became allergic.
  • Instead of an onset date, we should focus on just recording the comments alone
  • OpenMRS' data model and FHIR2 API do not require an onset date for allergies.
  • The backend currently sets it to today’s date by default, which may not always be accurate.

Screenshots

Screenshot 2025-01-28 at 9 27 26 PM Screenshot 2025-01-28 at 9 27 50 PM

Related Issue

https://issues.openmrs.org/browse/O3-4342

Other

@Muppasanipraneeth
Copy link
Contributor Author

@denniskigen

@denniskigen
Copy link
Member

@Muppasanipraneeth could you add some context about why we're removing the onset date field to your PR description? I think you can find it in the discussion on the issue thread on Jira.

@Muppasanipraneeth
Copy link
Contributor Author

@Muppasanipraneeth could you add some context about why we're removing the onset date field to your PR description? I think you can find it in the discussion on the issue thread on Jira.

sure @denniskigen I will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants