(fix) Remove redundant escapeValue override in visit form translations #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes explicit `escapeValue:false` overrides in several translation interpolations in VisitForm workspace component. The `escapeValue: false` configuration was unnecessary since the interpolated date values don't contain HTML that needs to be preserved. This hardening measure ensures any special characters in interpolated values are properly escaped by default.
denniskigen
requested review from
vasharma05,
NethmiRodrigo,
ibacher and
samuelmale
|
Size Change: -26 B (0%) Total Size: 16.3 MB ℹ️ View Unchanged
|
|
Did you try removing the keys from translations file and test this again? |
Yes. I ran |
|
Still seeing this: |
|
Ah, I see. Thanks. I'll get to it in a bit. |
denniskigen
force-pushed
the
fix/remove-i18n-escapeValue-override
branch
from
ede7d5c to
06c1800
Compare
|
@vasharma05 should be fixed. Could you test again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR removes explicit
escapeValue: falseoverrides in several translation interpolations in VisitForm workspace component. The overrides are unnecessary since the interpolated date values don't contain HTML that needs to be preserved.This hardening measure ensures any special characters in interpolated values are properly escaped by default.
Screenshots
The interpolated translation strings for validations render in the UI as expected:
en-US
fr-FR
es-ES
Related Issue
Other