(fix) Notify config system when app is fully loaded #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -150 kB (-2.38%) Total Size: 6.15 MB
ℹ️ View Unchanged
|
brandones
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
This looks like a much better way to handle updating moduleLoaded.
Should we remove the line in defineConfigSchema?
I wonder if defining extension config works at all, and whether this fix will allow it to work. The fact that extension-config.test.tsx does not have any tests using defineExtensionConfigSchema gives me some pause.
Honestly, that's initially what I did and I got lazy fixing tests, but I think you're right.
It actually does:
This is just the obs-by-encounter widget added to a random slot with no additional config. Since it's showing something, the schema defaults are taking, so something is parsing the schema and correctly associating it. That said, it doesn't look like it should work to me... |
|
So, not marking the module as loaded at the end of |
|
This fixed https://openmrs.atlassian.net/browse/O3-4254 if I'm not mistaken |
|
@brandones Yes, though not as fully as I'd like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This is a companion commit for openmrs/openmrs-esm-patient-chart#2139. The underlying issue in that PR is that a module is only registered as loaded when
defineConfigSchema()is called, causing the promises used to load the configuration to never resolve whendefineConfigSchema()isn't called. (It is technically an error to calluseConfig()without having calleddefineConfigSchema(), but its unclear when to log this error since we can't always know when the config is read).This PR adds a call at the end of the app loading process to ensure that the module is marked as "loaded" in the configuration system.
Note that openmrs/openmrs-esm-patient-chart#2139 should still be committed even with this change.
Screenshots
Related Issue
Other