Add minimal value to all timestamp json definition #648
Conversation
The goal is to prevent the easy to make mistake of using a second timestamp instead of a millisecond timestamp.
tonial
force-pushed
the
timestamp_minimal_value
branch
from
a9054f1
to
ba5f1e7
Compare
schnuerle
added
Agency
|
Hi @thekaveman could you take a look at this? Is it ok to require all of these values exist and be greater than 0? Thanks. |
There was a problem hiding this comment.
This looks good to me!
Important to note this change doesn't impact any requirement for timestamps in any specific endpoint. It only changes the definition of a timestamp to be always greater than or equal to Jan 1, 2018 00:00:00 UTC.
A good example is in Provider /trips, the optional publication_time field. This change does not make the field required, it just dictates the lower bound if a value is given.
The change could impact testing scenarios or synthetic data generation that isn't using realistic time values, but IMHO is unlikely to impact real-world data producers in any meaningful way.
The goal is to prevent the easy to make mistake of using a second
timestamp instead of a millisecond timestamp.
This PR implements issue #645