Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about array Types to Provider #54

Merged
merged 2 commits into from
Sep 12, 2018

Conversation

sethherr
Copy link
Contributor

No description provided.

@thekaveman
Copy link
Collaborator

Unfortunately this changes the intention of those fields, @sethherr. These are meant to be arrays, e.g. a vehicle may have more than one propulsion_type. See the related discussion on #48.

@sethherr
Copy link
Contributor Author

Ahh. That's an important distinction, that Type declaration wasn't clear to me.

@thekaveman
Copy link
Collaborator

Indeed there is room for ambiguity. See our discussion on #46 and #53, where we are exploring JSON-Schema to more clearly define the spec in a machine-readable/machine-verifiable format.

@sethherr sethherr changed the title Remove unnecessary brackets from Provider Add a note about array Types to Provider Sep 12, 2018
@sethherr
Copy link
Contributor Author

I put a note about it being an array in the description, I think this would have clarified it for me?

I think JSON-Schema could be great, this is more of a quick fix...

Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clarification!

@thekaveman thekaveman merged commit 558e619 into openmobilityfoundation:master Sep 12, 2018
@sethherr sethherr deleted the patch-1 branch September 12, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants