Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDS-Agency Stops Specification #430

Conversation

avatarneil
Copy link
Contributor

@avatarneil avatarneil commented Jan 23, 2020

Explain pull request

This PR is a work in progress to reflect changes from #427 in MDS Agency .

Is this a breaking change

  • I'm not sure

Impacted Spec

  • agency

Additional context

Add any other context or screenshots about the feature request here.

@avatarneil avatarneil requested a review from a team January 23, 2020 19:48
@avatarneil avatarneil requested a review from a team as a code owner January 23, 2020 19:48
@sarob sarob added Agency Specific to the Agency API enhancement New feature or request labels Jan 27, 2020
@sarob sarob added this to the 0.4.1 milestone Feb 1, 2020
@thekaveman thekaveman modified the milestones: 0.4.1, Future Feb 13, 2020
@jfh01 jfh01 modified the milestones: Future, 1.0.0 Apr 9, 2020
Copy link
Contributor

@janedotx janedotx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add GET /stops to read multiple stops at a time. I suggest a response body that looks like { version: ..., stops: Stop[] }.

@Retzoh
Copy link
Contributor

Retzoh commented Jun 11, 2020

Why not have a single definition for stop payloads referenced by the agency and provider specs to make sure:

  1. They are compatible
  2. We won't see a drift in content, requiring us to do a re conciliation sometime in the future
    ?

@avatarneil
Copy link
Contributor Author

@Retzoh I'd be happy to move these changes over to the branch currently focused on the Provider changes, and merge the data definitions (though it probably won't get done by the City Services meeting today).

@Retzoh
Copy link
Contributor

Retzoh commented Jun 11, 2020

@avatarneil , let us ask this question during the city-services call today since docked is on the agenda

@schnuerle
Copy link
Member

See discussion on Provider Stops PR #427: #427 (comment)

@avatarneil avatarneil closed this Jun 12, 2020
@avatarneil avatarneil reopened this Jun 12, 2020
@avatarneil
Copy link
Contributor Author

Closing in favor of #427 which consolidates both the agency & provider changes needed

@avatarneil avatarneil closed this Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants