Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test if a PyTorch module receives corrects arguments #50

Merged
merged 3 commits into from
Jan 8, 2022
Merged

Test if a PyTorch module receives corrects arguments #50

merged 3 commits into from
Jan 8, 2022

Conversation

raimis
Copy link
Contributor

@raimis raimis commented Dec 13, 2021

  • Test device
  • Test precision
  • Test values

@raimis raimis mentioned this pull request Dec 14, 2021
Closed
@raimis raimis self-assigned this Jan 7, 2022
@raimis raimis marked this pull request as ready for review January 7, 2022 22:32
@raimis raimis requested a review from peastman January 7, 2022 22:32
@raimis
Copy link
Contributor Author

raimis commented Jan 7, 2022

@peastman this is ready too!

peastman
peastman approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@peastman peastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@raimis raimis merged commit 4614813 into openmm:master Jan 8, 2022
@dmighty007 dmighty007 mentioned this pull request Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peastman peastman peastman approved these changes

Assignees

@raimis raimis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raimis @peastman