refactor: mk webhook event type register non-critical #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgacsal
requested review from
sagikazarmark,
hekike,
tothandras,
turip and
GAlexIHU
chrisgacsal
force-pushed
the
fix-svix-timeout
branch
3 times, most recently
from
d7fc077 to
b97d49d
Compare
* make timeout for event type register operation configurable (`notification.webhook.eventTypeRegistrationTimeout`) * allow skipping event type register in case the first attempt was unsuccessful in order to allow the service to start even in degraded state. (`notification.webhook.skipEventTypeRegistrationOnError`)
chrisgacsal
force-pushed
the
fix-svix-timeout
branch
from
b97d49d to
d1dcef5
Compare
sagikazarmark
previously approved these changes
Oct 1, 2024
chrisgacsal
force-pushed
the
fix-svix-timeout
branch
from
d1dcef5 to
db06a75
Compare
sagikazarmark
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
notification.webhook.eventTypeRegisterTimeout)notification.webhook.skipEventTypeRegisterOnError)