test: added tests for mcp and workspace deletion #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors deletion logic and query hooks for managed control planes by extracting functionality into reusable custom hooks, improving code organization and testability.
Key changes:
- Created
useManagedControlPlanesQueryanduseDeleteManagedControlPlanehooks to encapsulate data fetching and deletion logic - Removed unused
isDeletingreturn value fromuseDeleteWorkspacehook - Updated components to use the new hooks with dependency injection for testability
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hooks/useManagedControlPlanesQuery.ts | New hook wrapping control planes query logic |
| src/hooks/useDeleteManagedControlPlane.ts | New hook encapsulating managed control plane deletion with patch-then-delete pattern |
| src/hooks/useDeleteManagedControlPlane.spec.ts | Unit tests for the new deletion hook |
| src/hooks/useDeleteWorkspace.ts | Removed unused isDeleting return value |
| src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx | Updated to use new query hook with dependency injection |
| src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.cy.tsx | New Cypress test verifying workspace deletion |
| src/components/ControlPlanes/ControlPlanesListMenu.tsx | Added test ID for E2E testing |
| src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCard.tsx | Refactored to use new deletion hook with dependency injection |
| src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCard.cy.tsx | New Cypress test verifying managed control plane deletion |
| src/components/ControlPlanes/ControlPlaneCard/ControlPlaneCardMenu.tsx | Added test ID for E2E testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.cy.tsx
Outdated
Show resolved
Hide resolved
…dTile.cy.tsx Co-authored-by: Copilot <[email protected]>
Hubert-Szczepanski-SAP
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for: