test: add tests for creating and updating MCP #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how managed control plane components are queried and how the update mutation is handled by extracting logic into reusable hooks. The main changes centralize API call logic and remove the now-obsolete isOnMcpPage flag that was previously used to conditionally enable API requests.
- Extracted component query logic into a dedicated
useComponentsQueryhook - Extracted MCP update logic into a dedicated
useUpdateManagedControlPlanehook - Removed the
isOnMcpPageparameter from the wizard chain, which is no longer needed since the hooks handle API calls unconditionally - Added comprehensive test coverage for the new hooks and edit scenarios
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/hooks/useUpdateManagedControlPlane.ts | New hook that encapsulates the update MCP mutation logic with proper crate configuration |
| src/hooks/useUpdateManagedControlPlane.spec.ts | Test coverage for the update MCP hook verifying correct PATCH requests |
| src/hooks/useCreateManagedControlPlane.ts | New hook that encapsulates the create MCP mutation logic |
| src/hooks/useCreateManagedControlPlane.spec.ts | Updated import path from .tsx to .ts extension |
| src/hooks/useComponentsQuery.ts | New hook that encapsulates component fetching with crate configuration |
| src/components/Wizards/CreateManagedControlPlane/useComponentsSelectionData.ts | Refactored to use the new useComponentsQuery hook instead of directly calling useApiResource |
| src/components/Wizards/CreateManagedControlPlane/EditManagedControlPlaneWizardDataLoader.tsx | Removed isOnMcpPage prop which is no longer needed |
| src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.tsx | Integrated new hooks and removed isOnMcpPage prop throughout |
| src/components/Wizards/CreateManagedControlPlane/CreateManagedControlPlaneWizardContainer.cy.tsx | Added comprehensive test coverage for create and edit scenarios |
| src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx | Removed unnecessary isEditMode={false} prop |
| src/spaces/mcp/pages/McpPage.tsx | Removed isOnMcpPage prop from wizard component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lucasgoral
approved these changes
Oct 31, 2025
Contributor
lucasgoral
left a comment
lucasgoral
left a comment
There was a problem hiding this comment.
Basic user flow is covered nicely and it has proper assertion. Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes tests covering:
It also removes the
isOnMcpPageparameter, which doesn’t appear to be necessary as far as I could see. That said, please feel free to validate the flows on your end to confirm there aren’t any edge cases I’ve missed. 🙏