Don't call normalize inside Tabular.mean #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @Asureda as this change might impact your workflow 👍 |
pshriwise
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Good call @paulromano. A definitely improvement over a sneaky normalization here. Thanks for this update. Will merge at the end of the day if there are no other comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've been using the
openmc.stats.Tabularclass to represent source energy spectra, it may not have an integral of 1; instead the integral corresponds to the source strength. One thing I noticed is that in this case, if you callmean()it will give you the correct value but it will also normalize the distribution, which is unwanted. This PR changes the behavior of themean()method so that it doesn't mutate the object.