Remove wgt_absorb data member from Particle #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gridley Let me know if you have further requests for changes |
|
LGTM! |
gridley
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, survival biasing relies on a data member in
Particlecalledwgt_absorb(weight absorbed). It turns out this is not necessary and can be calculated on-the-fly for tallies if needed. This PR removes thewgt_absorbmember and simplifies some logic related to survival biasing. Therussian_roulettefunction has been generalized and is now used for weight windows as well.One unrelated small fix is in here too -- I found a bug in
Halfspace.rotatewhen a rotation matrix is passed that is now fixed.