Return all bin indices for filters not specified in Tally.get_filter_indices
#1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
reviewed
Feb 15, 2022
pshriwise
force-pushed
the
bin_indices_opt
branch
from
b5bb2f9
to
e2c4324
Compare
paulromano
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a change when providing all indices of a filter's bins in
Tally.get_filter_indicesfor cases where the filter is not specified. Right now as the method collects bin indices for each filter on theTallyobject, the method callsFilter.get_bin_indexfor every filter bin regardless of whether or not specific bins were specified on the filter in the function call in thefiltersargument.The method should safely (and more quickly) be able to use a set of indices generated by
np.arange(len(bins))for filters not specified in thefiltersargument. As I understand it, this array is what would be produced were we to perform theFilter.get_bin_indexcalls sequentially anyway since we want the full set of bins.The downside here is that this approach bypasses some checking that occurs in each Filter's
get_bin_indexmethod. Looking at our current set of filters, it shouldn't be a problem, but there's a chance it might bite us in the future. Based on the patterns present for theEnergyFunctionFilter, however, I think the filter will be different enough that it will be clear what unique treatment is needed.