Particle restart logs

[GiudGiud]

I came across an interesting bug while looking at particles vanishing from a PB-FHR geometry.

The write_message routine is called in particle.cpp as : write_message("some string with {}", surface_id).

The intent of this is to have surface_id be recognized as a parameter of the string, and the templated write_message() routine can handle it throught a call to fmt::format
Unfortunately, the routine that ends up being called is write_message("some_string", log_level), so surface_id is not shown on screen.

I can't see an easy fix on the error.cpp side. Excluding "int" as a valid parameter in the template takes a bit of code and will be a bit confusing since it's the most common use case for this template. On the other hand, being able to write_message without specifying a level is also very convenient, so we do want int level=0 as an optional second parameter.
Having the templated write_message have a different name also slightly defeats the purpose.

I fixed the symptoms by adding the level to the problematic write_message logs.
Note: An alternative "symptoms" fix is to make surface id be a int64_t, just like particle ids.

[paulromano]

Hmmm, I see what you mean. I'm going to go ahead and merge this, but we do need a better solution. Would you mind opening up an issue describing this so we can keep track of it?

[GiudGiud]

done. Thanks for the review