Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add always builtin for run to force command to always run (but allow cached mounts) #147

Merged
merged 1 commit into from
May 19, 2020

Conversation

coryb
Copy link
Contributor

@coryb coryb commented May 17, 2020

The implementation is a bit of a hack. There does not seem to be a way via llb to make an exec call force a cache-miss other than llb.IgnoreCache, but that will also prevent any mounts from also using cache.

So this PR adds a random env var so that the vertex will always hash to a new digest while still allowing mount cache to be used.

Copy link
Contributor

@hinshun hinshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a tracking issue if there's a proper fix for upstream?

@coryb
Copy link
Contributor Author

coryb commented May 19, 2020

Created issue to remove hack when possible.

@coryb coryb merged commit 0073f10 into openllb:master May 19, 2020
@coryb coryb deleted the always-run branch December 19, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants