Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return None for non file: URIs #500

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

alcarney
Copy link
Collaborator

@alcarney alcarney commented Oct 5, 2024

As discussed in #209 this tweaks the to_fs_path function to return None when passed a URI that does not have a file: scheme.

This does have a few knock-on effects, but if anything it's going to highlight places where pygls makes some incorrect assumptions

Closes #209

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated linters

You can run the lints that are run on CI locally with:

poetry install --all-extras --with dev
poetry run poe lint

@alcarney alcarney force-pushed the to-fs-path branch 2 times, most recently from 7b09f31 to e084194 Compare October 5, 2024 21:29
@alcarney
Copy link
Collaborator Author

alcarney commented Oct 7, 2024

Thanks!

@alcarney alcarney merged commit 1c86cb3 into openlawlibrary:main Oct 7, 2024
16 checks passed
@alcarney alcarney deleted the to-fs-path branch October 7, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pygls only understands the file URI scheme.
2 participants