Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to lsprotocol-2024.0.0b1 #499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,10 @@
"language": "plaintext"
}
],
"python.testing.pytestArgs": [
"."
],
"python.testing.unittestEnabled": false,
"python.testing.pytestEnabled": true,
// "pygls.jsonServer.exampleConfiguration": "some value here",
}
1 change: 1 addition & 0 deletions examples/servers/code_actions.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def code_actions(params: types.CodeActionParams):
title=f"Evaluate '{match.group(0)}'",
kind=types.CodeActionKind.QuickFix,
edit=types.WorkspaceEdit(changes={document_uri: [text_edit]}),
tags=[types.CodeActionTag.LlmGenerated],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could drop this? It's nice to be able to show the new features of lsprotocol but I wonder if it might confuse someone new to language servers into thinking it's required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can. I will make the update.

)
items.append(action)

Expand Down
Loading
Loading