Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XGBoost package. #25

Merged
merged 7 commits into from
Sep 1, 2020
Merged

XGBoost package. #25

merged 7 commits into from
Sep 1, 2020

Conversation

t-kimber
Copy link
Contributor

Description

Include gradient boosting model (tree-based algorithm) which uses the XGBoost package.

Todos

  • Include package in conda yaml file.
  • Test model training in notebook.

Questions

  • How to efficiently include the package? e.g. .to_xgb?

Status

  • Ready to go

@t-kimber t-kimber mentioned this pull request Aug 19, 2020
Closed
@t-kimber t-kimber changed the title add xgboost package. XGBoost package. Aug 19, 2020
@jaimergp
Copy link
Collaborator

How to efficiently include the package? e.g. .to_xgb?

Definitely, to_xgboost can be provided at the DatasetProvider parent level.

jaimergp
jaimergp reviewed Aug 31, 2020
View reviewed changes
devtools/conda-envs/test_env.yaml
@@ -16,6 +16,7 @@ dependencies:
- tqdm
- pytorch 1.6
- torchvision
- xgboost
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need https://anaconda.org/conda-forge/py-xgboost? Also, something to note: I think conda-forge's does not offer GPU support yet. conda-forge/xgboost-feedstock#26

@jaimergp jaimergp merged commit 8036f2b into observation-model Sep 1, 2020
@jaimergp jaimergp deleted the xgboost branch September 1, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimergp jaimergp jaimergp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-kimber @jaimergp