Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

650 DMS with no authorization #757

Merged
merged 2 commits into from
Feb 10, 2021
Merged

650 DMS with no authorization #757

merged 2 commits into from
Feb 10, 2021

Conversation

galethil
Copy link
Collaborator

@galethil galethil commented Jan 25, 2021

Checklist

Description

This PR adds min.io instance into docker-compose and allow upload of documents to min.io container.
Backwards compatibility is maintained. Links to files are stored in multichain and can be used to get documents between organisations.

Closes #762

@galethil galethil force-pushed the 650-dms-no-auth branch 2 times, most recently from c0fc9f6 to 2569412 Compare February 2, 2021 09:55
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

Warnings
⚠️ There are new console logs in the API!
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 2cad6c9

@openkfwCI
Copy link

openkfwCI commented Feb 2, 2021

NotesTime
Note for Reviewer: E2E tests on remote server succeededWed, 10 Feb 2021 11:43:53 +0000

Generated by E2E-Test

@galethil galethil changed the title WIP: 650 dms no auth 650 DMS with no authorization Feb 2, 2021
@m-janos m-janos self-assigned this Feb 2, 2021
api/src/config/index.ts Outdated Show resolved Hide resolved
@galethil galethil force-pushed the 650-dms-no-auth branch 3 times, most recently from 787a0af to dbf69e2 Compare February 4, 2021 07:14
@m-janos m-janos assigned galethil and unassigned m-janos Feb 9, 2021
@Stezido Stezido force-pushed the 650-dms-no-auth branch 6 times, most recently from 8a1681c to f60d027 Compare February 9, 2021 15:51
@@ -0,0 +1,165 @@
import * as Minio from "minio";
import { v4 as uuid } from "uuid";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unused import.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed.

@Stezido Stezido merged commit 8428529 into master Feb 10, 2021
@Stezido Stezido deleted the 650-dms-no-auth branch March 8, 2021 15:30
Stezido added a commit that referenced this pull request Mar 15, 2021
This reverts commit 8428529, reversing
changes made to 1bc6832.
Stezido added a commit that referenced this pull request Mar 15, 2021
This reverts commit 8428529, reversing
changes made to 1bc6832.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document storage using min.io
5 participants