Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDPR warning for creating a user #479

Merged
merged 3 commits into from
May 11, 2020
Merged

GDPR warning for creating a user #479

merged 3 commits into from
May 11, 2020

Conversation

melissaSchmidt0302
Copy link
Contributor

Closes #466

@openkfwCI
Copy link

openkfwCI commented May 11, 2020 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on remote server succeededMon, 11 May 2020 14:38:17 +0000

Generated by E2E-Test

Stezido
Stezido suggested changes May 11, 2020
View reviewed changes
Copy link
Contributor

@Stezido Stezido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groups should have the same warning/info.
Be consistent and decide if the shown text is a warning or an information. A warning should be shown as yellow box while an information is shown as it is shown right now.

frontend/src/pages/Common/CreationDialog.js Outdated Show resolved Hide resolved
@Stezido Stezido merged commit e63d274 into master May 11, 2020
@Stezido Stezido deleted the gdpr-warning branch June 15, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stezido Stezido Stezido approved these changes

Assignees

@Stezido Stezido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a GDPR-warning when creating a user
3 participants
@melissaSchmidt0302 @openkfwCI @Stezido