Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add projected budget ratio #242

Merged
merged 5 commits into from
Apr 30, 2019
Merged

UI: Add projected budget ratio #242

merged 5 commits into from
Apr 30, 2019

Conversation

Stezido
Copy link
Contributor

@Stezido Stezido commented Apr 26, 2019

The ratio is calculated by dividing projectedBudget by totalBudget

Closes #231
Closes #230

The ratio is calculated by dividing projectedBudget/totalBudget
Copy link
Contributor

@mathiashoeld mathiashoeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to the changelog for this change

@Stezido Stezido assigned Stezido and unassigned gonzochic Apr 29, 2019
@Stezido Stezido assigned mathiashoeld and unassigned Stezido Apr 29, 2019
@Stezido Stezido removed the request for review from kevinbader April 29, 2019 12:47
CHANGELOG.md Outdated
<!-- ### Added -->
### Added

- Projected budget ratio to analytics on project level [#242](https://github.com/openkfw/TruBudget/pull/242)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with this sentence.

CHANGELOG.md Outdated
@@ -17,6 +19,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

- Fixed line of YAML file for master deployments via docker-compose, so that image of excel export service is pulled correctly [#223](https://github.com/openkfw/TruBudget/issues/223)
- Backup/restore works again. [#237](https://github.com/openkfw/TruBudget/issues/237)
- Budgets on project analytics do not contain open workflow items anymore [#230](https://github.com/openkfw/TruBudget/issues/230)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "anymore"

@Stezido Stezido requested review from mathiashoeld and gonzochic and removed request for mathiashoeld April 29, 2019 13:20
mathiashoeld
mathiashoeld previously approved these changes Apr 29, 2019
@Stezido Stezido merged commit 32e1b38 into master Apr 30, 2019
@Stezido Stezido deleted the analytics-adjustment branch April 30, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants